Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create Expense] Submits To Display Name Missing #56609

Open
grgia opened this issue Feb 10, 2025 · 13 comments
Open

[Create Expense] Submits To Display Name Missing #56609

grgia opened this issue Feb 10, 2025 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Feb 10, 2025

Original Thread

Problem:

  • getAccountsByID is failing to retrieve the "Submits To" display name in workspaces with a large number of members.
  • Possible cause is Onyx might not fully load objects when an array (e.g., employeeList) contains many records, causing missing properties.

Repro Steps:

  1. Add yourself to a workspace with very large group of members. (e.g. policyID: 8A152FCBCD316665)
  2. Click on the FAB > Create Expense.
  3. Go to the participant list and verify that for most workspaces it shows Submits to but ones with large members doesn't show.

Debug Findings:

  • Adding debug logs in ReportUtils.ts confirms that submitsToAccountDetails is sometimes undefined.
@grgia grgia added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 10, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@JKobrynski
Copy link
Contributor

HI I'm Julian from Callstack and I'd like to work on this issue

@JKobrynski
Copy link
Contributor

Update:

I started working on this issue today.

@JKobrynski
Copy link
Contributor

Update:

I wanted to check if #56770 fixes this issue but unfortunately it doesn't. I am still able to reproduce it on that other branch, using a workspace that has many members on iOS.

@JKobrynski
Copy link
Contributor

FYI I'm going to be OOO next week, coming back on Monday February 24th.

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2025
@mananjadhav
Copy link
Collaborator

Will be picked by @JKobrynski once they're back from OOO.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 17, 2025
@grgia grgia added Weekly KSv2 and removed Daily KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2025
@grgia
Copy link
Contributor Author

grgia commented Feb 20, 2025

Making weekly until Julian's back

Copy link

melvin-bot bot commented Feb 24, 2025

@mananjadhav @alexpensify @grgia @JKobrynski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@JKobrynski
Copy link
Contributor

@grgia @mananjadhav I'm back, it can be daily again!

@grgia
Copy link
Contributor Author

grgia commented Feb 24, 2025

WOOP

@grgia grgia added Daily KSv2 and removed Weekly KSv2 labels Feb 24, 2025
@JKobrynski
Copy link
Contributor

Update:

I spent some time on further debugging this issue, no clear solutions yet.

@JKobrynski
Copy link
Contributor

Update:

I had more time today so I did a lot of testing and debugging on different platforms and accounts. It's interesting because it wouldn't reproduce for users who only have 1-2 workspaces (including Applause's Workspace 1).

Moreover, now it also reproduces for me on the web, not only iOS.

This is just an FYI, still looking for a fix!

@JKobrynski
Copy link
Contributor

Update:

The PR is ready for review!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants