Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AuthExampleIT flaky test #10024

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

fix: AuthExampleIT flaky test #10024

wants to merge 8 commits into from

Conversation

ldetmer
Copy link
Contributor

@ldetmer ldetmer commented Feb 11, 2025 •
edited
Loading

there was a race condition when running auth test where keys were getting deleted while still being used, so make each key name unique

Fixes #10023

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ldetmer
fix: there was a race condition when running auth test where keys wer…
cd6f473 
…e getting deleted while still being used, so make each key name unique
@ldetmer ldetmer requested review from yoshi-approver and a team as code owners February 11, 2025 21:20
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: auth labels Feb 11, 2025
@ldetmer ldetmer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2025
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 11, 2025
@ldetmer ldetmer marked this pull request as draft February 11, 2025 21:32
@ldetmer ldetmer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2025
@ldetmer ldetmer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2025
@ldetmer ldetmer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2025
@ldetmer ldetmer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Mukamik Mukamik

Labels
api: auth samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthExampleIT.testAuthApiKey test failing
3 participants
@ldetmer @Mukamik @kokoro-team