Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Flaky to be an ExceptionGroup #4040

Closed
jobh opened this issue Jul 11, 2024 · 0 comments · Fixed by #4043
Closed

Change Flaky to be an ExceptionGroup #4040

jobh opened this issue Jul 11, 2024 · 0 comments · Fixed by #4043
Labels
enhancement it's not broken, but we want it to be better legibility make errors helpful and Hypothesis grokable

Comments

@jobh
Copy link
Contributor

jobh commented Jul 11, 2024

Flaky can be caused by one or two different failures. Changing it to inherit BaseExceptionGroup will make it possible to improve reporting of the underlying exceptions.

see #4023 (comment)
@jobh jobh added enhancement it's not broken, but we want it to be better legibility make errors helpful and Hypothesis grokable labels Jul 11, 2024
@Zac-HD Zac-HD mentioned this issue Jul 12, 2024
Draft
33 tasks
@jobh jobh mentioned this issue Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement it's not broken, but we want it to be better legibility make errors helpful and Hypothesis grokable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Flaky into an ExceptionGroup jobh/hypothesis
1 participant
@jobh