Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ConvOperation3x has two extended_name methods? #2085

Open
henrylhtsang opened this issue Feb 7, 2025 · 2 comments
Open

[BUG] ConvOperation3x has two extended_name methods? #2085

henrylhtsang opened this issue Feb 7, 2025 · 2 comments
Labels
? - Needs Triage bug Something isn't working

Comments

@henrylhtsang
Copy link

Describe the bug
ConvOperation3x seems to have two methods both called extended_name. One depends on layouts of A and B. Which one is being used?

def extended_name(self):
core_name = self.core_name()
element_a = DataTypeNames[self.A.element]
element_b = DataTypeNames[self.B.element]
element_acc = DataTypeNames[self.tile_description.math_instruction.element_accumulator]
element_c = DataTypeNames[self.C.element]
element_d = DataTypeNames[self.D.element]
return f"{core_name}_{element_a}_{element_b}_{element_acc}_{element_c}_{element_d}"
def is_complex(self):
complex_operators = [
MathOperation.multiply_add_complex,
MathOperation.multiply_add_complex_gaussian,
MathOperation.multiply_add_complex_fast_f32
]
return self.tile_description.math_instruction.math_operation in complex_operators
def layout_names(self):
'''Layout strings for A and B, respectively'''
if self.is_complex():
return (ShortComplexLayoutNames[(self.A.layout, self.A.complex_transform)],
ShortComplexLayoutNames[(self.B.layout, self.B.complex_transform)])
else:
return (ShortLayoutTypeNames[self.A.layout],
ShortLayoutTypeNames[self.B.layout])
def extended_name(self):

Steps/Code to reproduce bug
Search def extended_name(self): in the link above.

Expected behavior
One method called extended_name

Environment details (please complete the following information):
trunk

Additional context
NA

@henrylhtsang henrylhtsang added ? - Needs Triage bug Something isn't working labels Feb 7, 2025
@hwu36
Copy link
Collaborator

hwu36 commented Feb 11, 2025

@Junkai-Wu

@Junkai-Wu
Copy link
Contributor

This should be a bug in current convolution compiler. I'll refactor the convolution compiler and fix this soon. Thanks for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants