Connection Request Detail Block Transfer Dropdown Includes Inactive Connection Opportunities

[billdeitrick]

Description

Reported on behalf of First Baptist Concord Church in Knoxville, TN.

The Connection Request Detail block's transfer dropdown includes inactive connection opportunities as options for transfer. This is inconsistent with the behavior of the transfer dropdown on the Connection Request Board block, which does not include inactive connection opportunities.

It appears the GetConnectionTypeViewModels method on Connection Request Board block handles filtering out inactive opportunities. The Connection Request Detail block populates the data differently and does not include a check to verify that the displayed opportunities are active.

Actual Behavior

The Connection Request Detail Block's transfer dropdown includes inactive connection opportunities, inconsistently with the behavior of the Connection Request Board block.

Expected Behavior

The Connection Request Detail block should use the same behavior as the Connection Request Board block and hide inactive connection opportunities from the transfer dropdown.

Steps to Reproduce

On Rock Solid Demo or the Prealpha site, navigate to and inactivate the "Usher" connection opportunity.

Navigate to the Connection Board, and open a connection request in one of the remaining active opportunities. Click the Transfer button and note that the inactivated "Usher" opportunity is not displayed in the dropdown list.

Navigate to the same connection request using the Connection Request Detail block and click the transfer button. Note that the inactive "Usher" opportunity is still displayed as a transfer target, unlike when the same procedure is performed from the Connection Board block.

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

1.16.4 (also confirmed on pre-alpha 17.0.37)

Client Culture Setting

en-US