Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason virtnbd-nbdkit-plugin is in /usr/bin? #253

Open
cmadamsgit opened this issue Feb 26, 2025 · 1 comment
Open

Is there a reason virtnbd-nbdkit-plugin is in /usr/bin? #253

cmadamsgit opened this issue Feb 26, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@cmadamsgit
Copy link

virtnbd-nbdkit-plugin gets installed in /usr/bin, as a non-executable file. That triggers errors from rpmlint for example. The proper place to me (at least in a packaged install) would be /usr/share.

I'm looking at submitting a package to Fedora, and I expect that would be a blocker. I could use a downstream patch to move it to /usr/share, and change libvirtnbdbackup/map/requirements.py to hard-code the path (which should be fine for an RPM install anyway), but wanted to check before making such a change.

rpmlint also doesn't like the shebang lines at the start of the module files (which aren't needed so will probably also strip out for an RPM).

@cmadamsgit cmadamsgit added the enhancement New feature or request label Feb 26, 2025
@abbbi
Copy link
Owner

abbbi commented Feb 26, 2025

no real reason for that, it was just the simplest solution i picked back in the days. Not sure if i want to change that currently, the debian packages install in the same path and the linters are fine with it ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants