Dockerize the project

[afaneca]

[mariushosting]

Any update on this?

[michaelze]

@afaneca
I'd be happy to contribute as I'm about to try and setup myfin on my NAS.
As this project consists of a separate API and frontend maybe we should have a discussion first about how to set this all up...
I'll make a suggestion in the next couple of days, if you are interested!

[afaneca]

@mariushosting @michaelze
I'm currently implementing integration tests with Docker for the API (see afaneca/myfin-api#100), but I still don't have a lot of experience with Docker and containerization in general.

I'll try to look into this in the coming few weeks and I'm more than open to hear your thoughts and get your contributions :)

[duckimann]

@afaneca i would suggest having both the frontend and the api in the same repository (you can take a look at Immich as an example). My reason for the suggestion is: like a monorepo, everything is in the same repo, i can build both frontend and api at the same time, without cloning the other repository. In addition, we still have ability to release separated docker images for each service if needed

[afaneca]

@duckimann MyFin actually started as a monorepo when it was just a REST API and a web frontend. However, since the API now powers both the web frontend and the android app (and could potentially support even more clients/frontends in the future, it was designed to be flexible), I'm not sure coupling the API and web frontend would be a good idea, as it could complicate release and version management. That said, I'll keep the idea in mind as I reflect further. In the mean time, feel free to keep the discussion going!

[denbatte]

I am a bit suprised.

Your app is mentioned on xda https://www.xda-developers.com/containers-change-life-host-on-nas/
This is how I came here.

Seems like the docker container is not a thing yet 😄
Will keep an eye on this post.

[mariushosting]

I am a bit suprised.

Your app is mentioned on xda https://www.xda-developers.com/containers-change-life-host-on-nas/ This is how I came here.

Seems like the docker container is not a thing yet 😄 Will keep an eye on this post.

Can you please stop spamming this AI generated content website?

[afaneca]

I am a bit suprised.

Your app is mentioned on xda https://www.xda-developers.com/containers-change-life-host-on-nas/ This is how I came here.

Seems like the docker container is not a thing yet 😄 Will keep an eye on this post.

@denbatte I just became aware of that article. As of right now, we do not offer docker integration. Hopefully we can make it happen over the next few weeks!

[TimoFrancke-cnic]

I know I came here via that article! I wonder if someone else has already made a docker image, but it's gotten outdated.

[duckimann]

@afaneca can i use a reverse proxy to send requests to the api? 🤔 i'm planned to "hard-code" the api path at build and use reverse proxy to connect but i can't get it to work

[afaneca]

@afaneca can i use a reverse proxy to send requests to the api? 🤔 i'm planned to "hard-code" the api path at build and use reverse proxy to connect but i can't get it to work

Yes, you should be able to. Please take a look at the Getting Started docs for both the api and frontend, it should give you the help you need.

[afaneca]

A new PR has been opened by @muhiris which adds dockerization to the frontend app. I haven't had the time to review it just yet, but would appreciate whatever input you guys might have on it: #415

[afaneca]

I just integrated our dockerization workflow in myfin-api. As of this moment, you can already access the current docker image (for the API) through ghcr, here.

The frontend integration will be coming next.

[afaneca]

Now the docker image for the web frontend is also available through ghcr, here.

We also made available a docker compose file to bootstrap the launch of the whole platform (api + web) from a single command.

Next steps include eventually creating a new all-in-one image, so that you can integrate both the api and frontend from a single, self-contained image.

[TimoFrancke-cnic]

I tried to use docker-compose.yml and got the following error. was a URL missed for the image location?

Error response from daemon: pull access denied for myfin-web, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

[afaneca]

@TimoFrancke-cnic there was indeed an issue with the image urls in the docker compose file. Just released an update to it, it should now work.

[TimoFrancke-cnic]

Yep, that did it. couldn't find it on Docker hub, so assumed it was hosted on GHCR, but I didn't see mention of a URL.

[mariushosting]

Now the docker image for the web frontend is also available through ghcr, here.

We also made available a docker compose file to bootstrap the launch of the whole platform (api + web) from a single command.

Next steps include eventually creating a new all-in-one image, so that you can integrate both the api and frontend from a single, self-contained image.

Is there any timeline for the all-in-one image? Thank you Antonio!

[afaneca]

No ETA at this moment, but I'll keep you posted through this discussion!

[TimoFrancke-cnic]

Would there be efficiency benefits from combining them? Having them separate with a provided docker-compose should be fine, and would likely make customization easier, no?

[afaneca]

I too think that having them as separate images adds flexibility. The idea of an all-in-one image is just an addition (wouldn't replace the docker compose integration path we already have) targeted at people that can't/won't use Docker Compose

[TimoFrancke-cnic]

I was working on implementing this behind a reverse proxy, and started an Issue regarding the security issue of having the API exposed. I guess the API should be exposed anyways for the app, right?

[afaneca]

Yep, that's right.