Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unknown start of token error message for invisible characters #1016

Closed
casey opened this issue Nov 4, 2021 · 0 comments · Fixed by #2637
Closed

Improve unknown start of token error message for invisible characters #1016

casey opened this issue Nov 4, 2021 · 0 comments · Fixed by #2637
Labels

Comments

@casey
Copy link
Owner

casey commented Nov 4, 2021

This came up because someone had a BOM in their justfile, which just was choking on.

The error message looked like:

error: Unknown start of token:
  |
1 | test:
  | ^

We should print the unknown start of token message such that invisible characters show up, for example by surrounding the offending character in quotes. We could also think about displaying non-printing characters as unicode escape sequences. Perhaps there's a function in the standard library that helps with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant