fix(yargs): specify types for every CLI option #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
bugfixes/876-yargs-option-types
branch
from
bc22780 to
eb42885
Compare
webknjaz
force-pushed
the
bugfixes/876-yargs-option-types
branch
from
eb42885 to
607c8b4
Compare
Codecov Report
@@ Coverage Diff @@
## main #878 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 35 35
Lines 1222 1222
Branches 249 249
=======================================
Hits 1126 1126
Misses 64 64
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@drazisil-codecov @thomasrockhu-codecov @mitchell-codecov ☝️ this is an easy merge, but it fixes a serious bug with flags being corrupted on upload. Mind taking a look? ☝️ |
|
@drazisil-codecov thanks! Do you think a new release with this could be expedited? |
|
@drazisil-codecov Yep, just checking what else is pending so I can make it worth it :D |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #876
(see the backstory/archeology/investigation 🕵️♂️ in that issue linked above)