Refactor the type system #1441
Draft
Refactor the type system #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
added
enhancement
structured generation
This was
linked to
issues
Feb 23, 2025
rlouf
force-pushed
the
types
branch
3 times, most recently
from
a41a411 to
69fb69b
Compare
|
I am fairly happy with where I got so far with the Gemini integration. We will obviously need a set of utility functions for the types: |
We are currently using intermediate `Json`, `Choice` and `List` classes which, in addition to being cumbersome, are not useful abstractions. This commit bypasses these abstractions to handle the output types directly at the level of `GeminiTypeAdapter`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #1433. Closes #1421. Closes #1420. Closes #1218. Closes #1223.