Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update animation class condition to improve Ribbon styling #4392

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Dec 30, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from Jocs as a code owner December 30, 2024 14:41
@jikkai jikkai force-pushed the fix/header-component branch from 99aa44f to 876c14c Compare December 30, 2024 14:41
Copy link

github-actions bot commented Dec 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 30, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  876c14c
info  For more information, see full report

@jikkai jikkai merged commit 0124730 into dev Dec 30, 2024
9 checks passed
@jikkai jikkai deleted the fix/header-component branch December 30, 2024 14:52
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.32%. Comparing base (0c31545) to head (876c14c).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/ui/src/views/components/ribbon/Ribbon.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4392      +/-   ##
==========================================
- Coverage   33.33%   33.32%   -0.02%     
==========================================
  Files        2528     2528              
  Lines      130532   130533       +1     
  Branches    29141    29142       +1     
==========================================
- Hits        43516    43495      -21     
- Misses      87016    87038      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant