Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): use different isNullCell for formula modules #4395

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Dec 31, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested a review from Dushusir as a code owner December 31, 2024 06:48
Copy link

github-actions bot commented Dec 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 31, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 44 seconds
commit  4840379
info  For more information, see full report

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.33%. Comparing base (a90779e) to head (4840379).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/engine-formula/src/services/runtime.service.ts 0.00% 3 Missing ⚠️
packages/engine-formula/src/basics/is-null-cell.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4395   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files        2528     2529    +1     
  Lines      130552   130563   +11     
  Branches    29147    29151    +4     
=======================================
+ Hits        43516    43526   +10     
- Misses      87036    87037    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 72e8192 into dev Jan 2, 2025
9 checks passed
@wzhudev wzhudev deleted the fix/formula-is-empty-cell branch January 2, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants