Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(facade): f-event & f-enum extend error #4424

Merged
merged 1 commit into from
Jan 4, 2025
Merged

fix(facade): f-event & f-enum extend error #4424

merged 1 commit into from
Jan 4, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 4, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from VicKun4937 as a code owner January 4, 2025 03:27
Copy link

github-actions bot commented Jan 4, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 4, 2025

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  d9f23d0
info  For more information, see full report

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 33.11%. Comparing base (fc23fec) to head (d9f23d0).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/facade/f-enum.ts 0.00% 10 Missing ⚠️
packages/core/src/facade/f-event.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4424      +/-   ##
==========================================
- Coverage   33.13%   33.11%   -0.03%     
==========================================
  Files        2549     2549              
  Lines      131451   131469      +18     
  Branches    29290    29294       +4     
==========================================
- Hits        43562    43541      -21     
- Misses      87889    87928      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit be77c47 into dev Jan 4, 2025
9 checks passed
@weird94 weird94 deleted the fix/extend-error branch January 4, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants