Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element clients hide from the user why a rageshake was rejected #29288

Open
davidegirardi opened this issue Feb 18, 2025 · 3 comments
Open

Element clients hide from the user why a rageshake was rejected #29288

davidegirardi opened this issue Feb 18, 2025 · 3 comments
Labels
A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions T-Enhancement X-Blocked

Comments

@davidegirardi
Copy link

davidegirardi commented Feb 18, 2025

Please read details on the meta issue: element-hq/element-meta#2732

@dosubot dosubot bot added the A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions label Feb 18, 2025
@davidegirardi
Copy link
Author

This is what the rejection HTTP messages look like:

HTTP/1.1 400 Bad Request
Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept
Access-Control-Allow-Methods: POST, OPTIONS
Access-Control-Allow-Origin: *
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Tue, 18 Feb 2025 09:01:11 GMT
Content-Length: 192

This server did not accept the rageshake because it matches a rejection condition: app or user text rejected. See https://github.com/matrix-org/rageshake/blob/master/docs/blocked_rageshake.md
HTTP/1.1 400 Bad Request
Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept
Access-Control-Allow-Methods: POST, OPTIONS
Access-Control-Allow-Origin: *
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Tue, 18 Feb 2025 09:01:56 GMT
Content-Length: 222

This server did not accept the rageshake because it matches a rejection condition: it matches a recovery key and recovery keys are private. See https://github.com/matrix-org/rageshake/blob/master/docs/blocked_rageshake.md

An accepted rageshake looks like this:

HTTP/1.1 200 OK
Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept
Access-Control-Allow-Methods: POST, OPTIONS
Access-Control-Allow-Origin: *
Content-Type: application/json
Date: Tue, 18 Feb 2025 09:02:13 GMT
Content-Length: 3

{}

Be mindful of injections :)

@t3chguy
Copy link
Member

t3chguy commented Feb 18, 2025

that text is not i18n friendly, really it should be using error codes so they can be translated by the app, not everyone can read technical English.

@davidegirardi
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions T-Enhancement X-Blocked
Projects
None yet
Development

No branches or pull requests

2 participants