Whitespaces are significant

[xzfc]

Example

This pattern:

language js
`switch(a){ }`

matches only the second line:

switch(a){}     // 1: no match
switch(a){ }    // 2: match
switch(a){  }   // 3: no match

Which is highly inconvenient when doing multi-line migrations as rules need to have precisely the same indentations as the code.

Clue

As I can see, this happen for node types that capture their descendants via "children" rather than "fields". E.g. it's an issue for switch_body:

gritql/resources/node-types/javascript-node-types.json

Lines 3157 to 3175 in 5af841f

	{
	"type": "switch_body",
	"named": true,
	"fields": {},
	"children": {
	"multiple": true,
	"required": false,
	"types": [
	{
	"type": "switch_case",
	"named": true
	},
	{
	"type": "switch_default",
	"named": true
	}
	]
	}
	},

But it's not an issue for, e.g., an array:

gritql/resources/node-types/javascript-node-types.json

Lines 308 to 331 in 5af841f

	{
	"type": "array",
	"named": true,
	"fields": {
	"elements": {
	"multiple": true,
	"required": false,
	"types": [
	{
	"type": ",",
	"named": false
	},
	{
	"type": "expression",
	"named": true
	},
	{
	"type": "spread_element",
	"named": true
	}
	]
	}
	}
	},

Workaround?

In the meantime, what workaround/quick fixes available to run multi-line migrations? I need some guidance.

• Fix grammar.js and *-node-types.json to use "fields"?
• Rewrite my rules using ast nodes instead of snippets?
• Somehow fix spacing for "children"?

[morgante]

The easiest solution is changing grammar.js but ideally we would fix spacing for children as well.