You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And these tests are missing an additional Lock, InboxForActor, Unlock for each recipient:
--- FAIL: TestDeliver/ReturnsErrorIfBatchDeliverFails (0.00s)
side_effect_actor.go:687: Unexpected call to *pub.MockDatabase.Lock([context.Background https://other.example.com/dakota]) at /home/michael/projects/activity/pub/mock_database_test.go:235 because:
Expected call at /home/michael/projects/activity/pub/side_effect_actor_test.go:1637 doesn't match the argument at index 1.
Got: https://other.example.com/dakota
Want: is equal to https://example.com/addison/outbox
Expected call at /home/michael/projects/activity/pub/side_effect_actor_test.go:1641 doesn't match the argument at index 1.
Got: https://other.example.com/dakota
Want: is equal to https://maybe.example.com/person
I've actually already fixed these broken tests, but in the process of submitting a PR, I noticed that you require an issue be submitted first, so here's my issue. I'll submit a follow-up PR with my fix.
The text was updated successfully, but these errors were encountered:
I haven't started using this library yet, but I noticed that the tests are broken. Specifically, there's a missing
Host
header here:And these tests are missing an additional
Lock
,InboxForActor
,Unlock
for each recipient:I've actually already fixed these broken tests, but in the process of submitting a PR, I noticed that you require an issue be submitted first, so here's my issue. I'll submit a follow-up PR with my fix.
The text was updated successfully, but these errors were encountered: