Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate WebRTC Direct certificates #2989

Open
achingbrain opened this issue Feb 22, 2025 · 2 comments · May be fixed by #2997
Open

Rotate WebRTC Direct certificates #2989

achingbrain opened this issue Feb 22, 2025 · 2 comments · May be fixed by #2997
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@achingbrain
Copy link
Member

At the moment we configure one long-lived certificate for WebRTC Direct. Instead we should make the duration configurable and generate a new certificate when we approach the expiry date.

When a new certificate is generated, the "listening" event should be re-emitted so the transport manager updates our peer record which will cause identify-push to notify connected peers that our addresses have changed.

@achingbrain achingbrain added need/triage Needs initial labeling and prioritization kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue good first issue Good issue for new contributors and removed need/triage Needs initial labeling and prioritization labels Feb 22, 2025
@Aryakoste
Copy link

Hello @achingbrain I would like to work on this issue.

@achingbrain
Copy link
Member Author

Wonderful, please open a PR with some tests!

@Aryakoste Aryakoste linked a pull request Feb 23, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants