Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GithubIdentity into RepositoryIdentity that works for GitLab and Bitbucket #1427

Closed
andrew opened this issue May 15, 2017 · 1 comment

Comments

@andrew
Copy link
Contributor

andrew commented May 15, 2017

Follow on from #1169 and #1344

We have removed the GitHub specific bits for repository owners but still have a number of functions for logged in users that only work for GitHub, most of which are tucked away in https://github.com/librariesio/libraries.io/blob/master/app/models/concerns/github_identity.rb

This needs to be moved onto their own classes which should be available via the identity model, which a user can have multiple of, this should enable GitLab and Bitbucket users to:

  • Sync their org/group/team memberships and repositories they have access to
  • Monitor repository dependencies

n.b. private repo functionality may need new oauth apps with extra permissions for GL/BB

@andrew
Copy link
Contributor Author

andrew commented Oct 9, 2017

Moving this to the Backlog as we'd still like to implement it but can't see that happening in the near future.

@andrew andrew closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant