Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent default browser behavior for failure/pass links #1572

Closed
wants to merge 1 commit into from
Closed

Prevent default browser behavior for failure/pass links #1572

wants to merge 1 commit into from

Conversation

jschilli
Copy link

@jschilli jschilli commented Mar 1, 2015

Changed href in HTML reporter to prevent default behavior.

This can be an issue when using mocha in integration testing with a booted application (ember in my case)

@jbnicolai
Copy link

@jbryson3 I suppose the reason is that the css styling is different when you leave the href (no cursor change on hover, for instance).

@jschilli merged, but changed the noop to javascript:void(0);

@jbnicolai jbnicolai closed this in f3c2a0a Jun 5, 2015
@jschilli
Copy link
Author

jschilli commented Jun 5, 2015

@jbnicolai - thanks - much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jschilli @jbnicolai @jbryson3 @jschiq2