fix(plugin): ensure to keep jsdoc with properties

ngxtension · Jan 12, 2024 · cc8731f · cc8731f
1 parent f2e99bf
commit cc8731f
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 13 deletions.
diff --git a/libs/plugin/src/generators/convert-signal-inputs/__snapshots__/generator.spec.ts.snap b/libs/plugin/src/generators/convert-signal-inputs/__snapshots__/generator.spec.ts.snap
@@ -32,15 +32,15 @@ import { input } from "@angular/core";
 export class MyCmp {
   inputWithoutType = input();
   normalInput = input('');
-  withoutDefault = input<string| undefined>();
+  withoutDefault = input<string | undefined>();
   withoutDefaultUnion = input<string | undefined>();
-  withDefaultAlias = input(123, {alias: 'defaultAlias'});
-  withoutDefaultAlias = input<number| undefined>(undefined, {alias: 'noDefaultAlias'});
+  withDefaultAlias = input(123, { alias: 'defaultAlias' });
+  withoutDefaultAlias = input<number | undefined>(undefined, { alias: 'noDefaultAlias' });
   justAStringAlias = input('', { alias: 'stringAlias' });
-  withTransform = input<boolean,string | ''>(booleanAttribute(false), {transform: booleanAttribute});
+  withTransform = input<boolean, string | ''>(booleanAttribute(false), { transform: booleanAttribute });
   requiredInput = input.required<string>();
-  requiredWithAlias = input.required<boolean>({alias: 'requiredAlias'});
-  requiredWithAliasAndTransform = input.required<number,string | ''>({alias: 'transformedRequiredAlias', transform: numberAttribute});
+  requiredWithAlias = input.required<boolean>({ alias: 'requiredAlias' });
+  requiredWithAliasAndTransform = input.required<number, string | ''>({ alias: 'transformedRequiredAlias', transform: numberAttribute });
 
   @Input() set leaveMeAlone(value: number) {
     console.log('setter', value);
@@ -89,15 +89,18 @@ import { input } from "@angular/core";
 export class MyCmp {
   inputWithoutType = input();
   normalInput = input('');
-  withoutDefault = input<string| undefined>();
+  withoutDefault = input<string | undefined>();
   withoutDefaultUnion = input<string | undefined>();
-  withDefaultAlias = input(123, {alias: 'defaultAlias'});
-  withoutDefaultAlias = input<number| undefined>(undefined, {alias: 'noDefaultAlias'});
+  withDefaultAlias = input(123, { alias: 'defaultAlias' });
+  withoutDefaultAlias = input<number | undefined>(undefined, { alias: 'noDefaultAlias' });
   justAStringAlias = input('', { alias: 'stringAlias' });
-  withTransform = input<boolean,string | ''>(booleanAttribute(false), {transform: booleanAttribute});
+  withTransform = input<boolean, string | ''>(booleanAttribute(false), { transform: booleanAttribute });
   requiredInput = input.required<string>();
-  requiredWithAlias = input.required<boolean>({alias: 'requiredAlias'});
-  requiredWithAliasAndTransform = input.required<number,string | ''>({alias: 'transformedRequiredAlias', transform: numberAttribute});
+  requiredWithAlias = input.required<boolean>({ alias: 'requiredAlias' });
+  /*
+   * @description I go with requiredWithAliasAndTransform
+   */
+  requiredWithAliasAndTransform = input.required<number, string | ''>({ alias: 'transformedRequiredAlias', transform: numberAttribute });
 
   @Input() set leaveMeAlone(value: number) {
     console.log('setter', value);

diff --git a/libs/plugin/src/generators/convert-signal-inputs/generator.spec.ts b/libs/plugin/src/generators/convert-signal-inputs/generator.spec.ts
@@ -97,6 +97,9 @@ export class MyCmp {
   @Input({ transform: booleanAttribute }) withTransform: string | '' = false;
   @Input({ required: true }) requiredInput!: string;
   @Input({ required: true, alias: 'requiredAlias' }) requiredWithAlias!: boolean;
+  /*
+   * @description I go with requiredWithAliasAndTransform
+   */
   @Input({ required: true, alias: 'transformedRequiredAlias', transform: numberAttribute }) requiredWithAliasAndTransform!: string | '';
 
   @Input() set leaveMeAlone(value: number) {

diff --git a/libs/plugin/src/generators/convert-signal-inputs/generator.ts b/libs/plugin/src/generators/convert-signal-inputs/generator.ts
@@ -298,7 +298,7 @@ export async function convertSignalInputsGenerator(
 							),
 						});
 
-						node.replaceWithText(newProperty.getText());
+						node.replaceWithText(newProperty.print());
 
 						// remove old class property Input
 						newProperty.remove();