Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signal-slice): typing for Subject action source with union type #169

Merged

Conversation

joshuamorony
Copy link
Contributor

Fixes an issue where if a Subject with a union type e.g Subject<number | null> was supplied as an actionSource the resulting typing for its action method would be incorrectly inferred as number & Observable<null>

Credit goes to @nartc for this one, all I did was nerd snipe him on Twitter

Copy link

nx-cloud bot commented Nov 21, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2bc7ffb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following targets are in progress

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@joshuamorony joshuamorony force-pushed the fix/signal-slice-action-source-subject branch from 7d67cf0 to 2bc7ffb Compare November 21, 2023 20:46
@nartc nartc merged commit 746c0fc into ngxtension:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants