feat: add collection for contributors #174
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8bbd35a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following targets are in progress
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| name: string; | ||
| twitter?: string; | ||
| linkedin?: string; | ||
| github?: string; |
There was a problem hiding this comment.
Minor: Later, when the contributors' data are added to the JSON files, we can mark this field as required.
Edit: This is more of reminder/note, please ignore
| "twitter": "https://twitter.com/laforge_toma", | ||
| "linkedin": "https://www.linkedin.com/in/thomas-laforge-2b05a945/", | ||
| "github": "https://github.com/tomalaforge" | ||
| } |
There was a problem hiding this comment.
Suggestion/Question: Should we consider only saving the username parts and creating the actual URLs in Contributor.astro?
| docs: docs, | ||
| i18n: i18n, | ||
| contributors: contributors, |
There was a problem hiding this comment.
nit: I prefer the shorthand, mainly due to this ES Lint rule. I have no strong opinions on this though.
| docs: docs, | |
| i18n: i18n, | |
| contributors: contributors, | |
| docs, | |
| i18n, | |
| contributors, |
To follow up on the contributor button and from the idea of @ajitzero, I added a new collection to collect contributors data where we can add a link to twitter, github, linkedin. Other link can be added.