-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(navigation-end): add navigationEnd util function #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you ran pnpm exec nx g @nx/angular:entry-point
. You should run pnpm exec nx g local-plugin:entry-point
instead. But it's ok, you can run pnpm exec nx g local-plugin:convert-entry-point-to-project
generator to convert navigation-end
to a separate project.
@all-contributors please add @va-stefanek for code |
I've put up a pull request to add @va-stefanek! 🎉 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ca159ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
* Creates an Observable that emits when a navigation ends. | ||
* @returns An Observable of NavigationEnd events. | ||
*/ | ||
export function navigationEnd(injector?: Injector): Observable<NavigationEnd> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call it injectNavigationEnd ?
Because that's what we do, we inject the router and return the navigation end.
This way it will be understood correctly what it does.
Just like we have injectResize.
What do you think @nartc @va-stefanek ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, let's go with It.
c506057
to
ca159ed
Compare
Thank you for your contribution |
closes #43