feat(rxjs): create a set of rxjs operators #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nartc
requested changes
Sep 18, 2023
| @@ -0,0 +1,22 @@ | |||
| --- | |||
| title: filter nil RxJs operator | |||
| description: ngxtension/filter-array | |||
| import { map, pipe } from 'rxjs'; | ||
|
|
||
| export const filterArray = <T>(filterFn: (item: T) => boolean) => { | ||
| return pipe(map((array: T[]) => array.filter((item) => filterFn(item)))); |
There was a problem hiding this comment.
suggestion: I'm pretty sure pipe() isn't needed.
| import { filter, pipe } from 'rxjs'; | ||
|
|
||
| export const filterNil = <T>() => | ||
| pipe( |
There was a problem hiding this comment.
suggestion: pipe() isn't needed
| import { map, pipe } from 'rxjs'; | ||
|
|
||
| export const mapArray = <T, R>(mapFn: (item: T) => R) => { | ||
| return pipe(map((array: T[]) => array.map((item) => mapFn(item)))); |
There was a problem hiding this comment.
suggestion: pipe() isn't needed
libs/ngxtension/project.json
Outdated
Comment on lines
43
to
46
| "libs/ngxtension/filter-array/**/*.ts", | ||
| "libs/ngxtension/filter-array/**/*.html", | ||
| "libs/ngxtension/filter-nil/**/*.ts", | ||
| "libs/ngxtension/filter-nil/**/*.html" |
|
@all-contributors please add @tomalaforge for code |
|
I've put up a pull request to add @tomalaforge! 🎉 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a074b12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
tomalaforge
force-pushed
the
feature/rxjs-operators
branch
from
b70a190 to
a074b12
Compare
|
thanks @nartc for reviewing my PR. Changes made |
nartc
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing issue #41