-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a signal base hostBinding function #81
Conversation
It's so cool! I was just thinking about a function like this a few days ago. This is an awesome PR. |
Glad you like it 😄! |
nice one 👍 |
Thanks! 😁 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cd953c4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you rebase?
@all-contributors please add @LcsGa for code |
I've put up a pull request to add @LcsGa! 🎉 |
Yes I can! But do you mean rebasing in order to have a single commit or to resolve conflicts or both (I use merge way more than rebase, except for when I want a clean branch, so I prefer asking 😅)? |
@LcsGa both |
cbcce97
to
cd953c4
Compare
@nartc Done! I hope I didn't do it wrong 😅 |
@LcsGa Thanks for the contribution! |
With pleasure 😄 |
As the title of the pull request suggests I added a
hostBinding
function that can be used to bind properties like@HostBinding
would, but to signals (either writable or readonly).As you would do to properties bound with the decorator, you are still able to set/update/mutate the signal if it is writable.