Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable google font variants (italic) #300

Closed
kochrt opened this issue Jan 5, 2025 · 1 comment
Closed

feat: Enable google font variants (italic) #300

kochrt opened this issue Jan 5, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@kochrt
Copy link

kochrt commented Jan 5, 2025

🆒 Your use case

It would be nice to be able to add italic to the font that is loaded from google fonts. I tried matching the api format that is used on the google fonts page, which would look something like Work+Sans:ital:400, but the logic in pure.ts assumes [family]:[weight] only.

const [name, weight] = f.split(':')

🆕 The solution you'd like

Specifying italic when adding a font works.

🔍 Alternatives you've considered

Downloading the fonts myself or just not using italic.

ℹ️ Additional info

No response

@kochrt kochrt added the enhancement New feature or request label Jan 5, 2025
@harlan-zw
Copy link
Collaborator

Hey, thanks for the suggestion. I'll consider this a bug as it should have already been supported through Work+Sans:ital:400.

I've pushed up a fix for it, let me know if you have any issues using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants