Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for security group overrides #9429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for security group overrides #9429

wants to merge 2 commits into from

Conversation

ethanchowell
Copy link

In C2S environments we don't have the option to create security groups. We can generally do everything else the installer wants to do, except security groups. CAPI specs allow security group overrides. Without this config, users in those envs are pushed to the opposite end of the spectrum using cloud formation which themselves need to be modified significantly due to access methods.

This PR adds support for mapping securityGroupOverrides to make openshift more accessible in those environments. I was able to backport this to 4.17 and verify in relevant environments.

Closes #9268

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

Hi @ethanchowell. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtulio mtulio Awaiting requested review from mtulio

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow AWS securityGroupOverrides
1 participant
@ethanchowell