Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Dropdown/Select/MenuContainer - tooltips do not work by default in items #11358

Open
kmcfaul opened this issue Dec 18, 2024 · 2 comments · May be fixed by #11567
Open

Bug - Dropdown/Select/MenuContainer - tooltips do not work by default in items #11358

kmcfaul opened this issue Dec 18, 2024 · 2 comments · May be fixed by #11567
Assignees
@nicolethoen
Labels
A11y
Milestone
2025.Q1

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Dec 18, 2024 •
edited
Loading

Because Tooltip wraps the trigger in a div, this interferes with the trigger/hover conditions so a tooltip will not appear. We should make it so Dropdown (and probably Select/MenuContainer will need this as well) creates an internal ref to use by default for tooltips, or we should make it so Tooltip does that internally.

Workaround: Create a reference, pass the ref to DropdownItem and the triggerRef field of tooltipProps.

Aside: Keyboard navigation still shows the tooltip, it is only the mouse that doesn't trigger it.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Dec 18, 2024
@kmcfaul kmcfaul removed the PF Team label Dec 18, 2024
@kmcfaul
Copy link
Contributor Author

kmcfaul commented Dec 18, 2024

Identified from OCP migration.

@thatblindgeye thatblindgeye changed the title Bug - Dropdown/Tooltip - tooltips do not work by default in dropdown items Bug - Dropdown/Select/MenuContainer - tooltips do not work by default in dropdown items Jan 9, 2025
@thatblindgeye thatblindgeye changed the title Bug - Dropdown/Select/MenuContainer - tooltips do not work by default in dropdown items Bug - Dropdown/Select/MenuContainer - tooltips do not work by default in items Jan 9, 2025
@thatblindgeye thatblindgeye moved this from Needs triage to Backlog in PatternFly Issues Jan 9, 2025
@thatblindgeye thatblindgeye added this to the 2025.Q1 milestone Jan 9, 2025
@rhamilto
Copy link
Member

@nicolethoen, can we get this prioritized so the tooltips in the console masthead can be added back?

@rhamilto rhamilto mentioned this issue Jan 22, 2025
Merged
11 tasks
@thatblindgeye thatblindgeye moved this from Backlog to Ready to assign in PatternFly Issues Jan 27, 2025
@nicolethoen nicolethoen self-assigned this Feb 3, 2025
@nicolethoen nicolethoen moved this from Ready to assign to In Progress in PatternFly Issues Feb 3, 2025
@andrewballantyne andrewballantyne mentioned this issue Feb 5, 2025
Merged
6 tasks
@thatblindgeye thatblindgeye marked this as a duplicate of #11327 Feb 17, 2025
@thatblindgeye thatblindgeye mentioned this issue Feb 17, 2025
Closed
@nicolethoen nicolethoen linked a pull request Feb 25, 2025 that will close this issue
Open
@nicolethoen nicolethoen moved this from In Progress to PR Review in PatternFly Issues Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
A11y
Projects
PatternFly Issues
Status: PR Review
Milestone
2025.Q1
Development

Successfully merging a pull request may close this issue.

fix(MenuItem): mouse can trigger tooltip on aria-disabled items nicolethoen/patternfly-react
4 participants
@rhamilto @nicolethoen @kmcfaul @thatblindgeye