Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Id length limit reached with composite key #4315

Closed
ofekd opened this issue Jan 18, 2023 · 2 comments · Fixed by #4317
Closed

Id length limit reached with composite key #4315

ofekd opened this issue Jan 18, 2023 · 2 comments · Fixed by #4317

Comments

@ofekd
Copy link

ofekd commented Jan 18, 2023 •
edited
Loading

I am using a composite of two UUIDs, and end up getting something like this with replication:

rx-storage-replication-pf7ru|ad5eccab-53a1-4e2e-bdbe-9e080536c3ce,eef351c3-1eca-4af2-bf9a-7a192028910b|0

Which is above the limit:

rxdb/src/replication-protocol/meta-instance.ts

Line 34 in 7607a8b

maxLength: 100

Thus errors out

RxDB v 13.17.1
@pubkey pubkey closed this as completed Jan 18, 2023
@pubkey pubkey reopened this Jan 18, 2023
@pubkey
Copy link
Owner

pubkey commented Jan 18, 2023 •
edited
Loading

Ok this is dangerous.
We should internally hash the id to ensure that the length is known, I will check.

@pubkey pubkey mentioned this issue Jan 19, 2023
Merged
@pubkey
Copy link
Owner

pubkey commented Jan 19, 2023

Fixed in #4317 together with some other refactorings.
Notice that this is a breaking change, so it will not be release on RxDB v13.

@jkinggg jkinggg mentioned this issue Jan 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR replication hash id pubkey/rxdb
2 participants
@ofekd @pubkey