Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve attribute naming #18

Open
linhsolar opened this issue Sep 17, 2023 · 1 comment
Open

improve attribute naming #18

linhsolar opened this issue Sep 17, 2023 · 1 comment

Comments

@linhsolar
Copy link
Contributor

quality attribute names should be improved to have a consistent way, e.g., some start with capital letters, some are not:
quality["ImageWidth"] = image.width
quality["ImageHeight"] = image.height
quality["ImageSize"] = image.size
quality["ColorMode"] = image.mode
quality["ColorChannel"] = len(image.getbands())
return quality

def eva_none(data):
try:
if is_pddataframe(data):
data = data.to_numpy()
if is_numpyarray(data):
valid_count = np.count_nonzero(~np.isnan(data))
none_count = np.count_nonzero(np.isnan(data))
results = {}
results["totalValid"] = valid_count
results["totalNone"] = none_count
results["noneRatio"] = valid_count/(valid_count+none_count)
return results

also catalog of attributes should be updated to reflect the attributes being supported.

@minhtribk12
Copy link
Contributor

attribute names updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants