Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom 'should be retried' logic #45

Open
stefanpl opened this issue Mar 30, 2021 · 2 comments
Open

Allow custom 'should be retried' logic #45

stefanpl opened this issue Mar 30, 2021 · 2 comments
Labels
enhancement help wanted

Comments

@stefanpl
Copy link

Following the discussion on #43:

Currently, I can only opt out of retrying by throwing an AbortError. It's not possible to opt in to retrying for the cases that p-retry does not deem to be retry-worthy.

I'll draft a PR so we have a base for discussion.
@stefanpl stefanpl mentioned this issue Mar 30, 2021
Closed
@sindresorhus
Copy link
Owner

If anyone wants to work on this, see the initial attempt and feedback in #46.

@marchuffnagle
Copy link

It looks like this was fixed by #75 , should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow for custom shouldBeRetried handler stefanpl/p-retry
3 participants
@sindresorhus @stefanpl @marchuffnagle