Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add syncClient.signalEvent #5

Merged
merged 2 commits into from
Oct 16, 2020
Merged

feat: add syncClient.signalEvent #5

merged 2 commits into from
Oct 16, 2020

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 16, 2020

This small PR is intended to restore the functionality of sdk-js which is broken due to the last updates to Testground and sdk-go (testground/sdk-go#31).

What this PR does:

  • Adds signalEvent to the sync client
  • Uses the events on network and runtime

What this PR does not do:

  • Add a watch client

License: MIT
Signed-off-by: Henrique Dias [email protected]

License: MIT
Signed-off-by: Henrique Dias <[email protected]>
License: MIT
Signed-off-by: Henrique Dias <[email protected]>
@hacdias hacdias requested a review from nonsense October 16, 2020 16:14
@hacdias hacdias marked this pull request as ready for review October 16, 2020 16:14
@hacdias
Copy link
Member Author

hacdias commented Oct 16, 2020

I'm merging this @nonsense, but please take a look afterwards!

@hacdias hacdias merged commit d4fc609 into master Oct 16, 2020
@hacdias hacdias deleted the events branch October 16, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant