4.23.0: not ready for pyupgrade --py39-plus

[kloczek]

Issue

End of this month python 3.8 will be EOSed.
I've tested tox code with patch generated by pyupgrade --py39-plus and looks like test suite is failing in few units.

Environment

Provide at least:

• OS: Linox x86/64

Output of pip list of the host Python, where tox is installed

Package                       Version
----------------------------- ------------
alabaster                     0.7.16
babel                         2.16.0
build                         1.2.2.post1
cachetools                    5.5.0
chardet                       5.2.0
charset-normalizer            3.4.0
click                         8.1.7
colorama                      0.4.6
defusedxml                    0.7.1
distlib                       0.3.8
distro                        1.9.0
docutils                      0.21.2
exceptiongroup                1.1.3
execnet                       2.1.1
filelock                      3.16.1
flaky                         3.8.1
hatch-vcs                     0.4.0
hatchling                     1.25.0
imagesize                     1.4.1
importlib_metadata            8.5.0
incremental                   22.10.0
iniconfig                     2.0.0
installer                     0.7.0
Jinja2                        3.1.4
MarkupSafe                    3.0.2
packaging                     24.0
pathspec                      0.12.1
platformdirs                  4.3.6
pluggy                        1.5.0
psutil                        6.0.0
Pygments                      2.18.0
pyproject-api                 1.8.0
pyproject_hooks               1.2.0
pytest                        8.2.2
pytest-mock                   3.14.0
pytest-xdist                  3.6.1
python-dateutil               2.9.0.post0
re_assert                     1.1.0
regex                         2024.9.11
requests                      2.32.3
setuptools                    75.1.0
setuptools-scm                8.1.0
snowballstemmer               2.2.0
Sphinx                        8.1.3
sphinx-argparse-cli           1.18.2
sphinx-autodoc-typehints      2.4.4
sphinx-copybutton             0.5.2
sphinx_inline_tabs            2023.4.21
sphinxcontrib-applehelp       2.0.0
sphinxcontrib-devhelp         1.0.6
sphinxcontrib-htmlhelp        2.1.0
sphinxcontrib-jsmath          1.0.1
sphinxcontrib-qthelp          2.0.0
sphinxcontrib-serializinghtml 2.0.0
time-machine                  2.16.0
tokenize_rt                   6.0.0
tomli                         2.0.1
towncrier                     23.11.1.dev0
trove-classifiers             2024.10.17
urllib3                       2.2.2
virtualenv                    20.27.0
wheel                         0.44.0
zipp                          3.20.2

Here is pytest summary output:

=========================== short test summary info ============================
SKIPPED [1] tests/session/cmd/test_devenv.py:18: integration tests not run (no --run-integration flag)
SKIPPED [1] tests/session/cmd/test_sequential.py:59: integration tests not run (no --run-integration flag)
SKIPPED [1] tests/session/cmd/test_sequential.py:159: integration tests not run (no --run-integration flag)
SKIPPED [1] tests/test_provision.py:131: integration tests not run (no --run-integration flag)
SKIPPED [1] tests/test_provision.py:164: integration tests not run (no --run-integration flag)
SKIPPED [2] tests/test_provision.py:198: integration tests not run (no --run-integration flag)
SKIPPED [1] tests/test_provision.py:221: integration tests not run (no --run-integration flag)
SKIPPED [2] tests/test_provision.py:230: integration tests not run (no --run-integration flag)
SKIPPED [1] tests/tox_env/python/virtual_env/test_setuptools.py:19: integration tests not run (no --run-integration flag)
FAILED tests/config/cli/test_cli_ini.py::test_ini_exhaustive_parallel_values
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader[value3-set-outcome3]
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader[value5-dict-outcome5]
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader[value15-set-outcome15]
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader[value16-list-outcome16]
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader[value17-dict-outcome17]
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader_fails_invalid[value1-set-ValueError-invalid literal for int]
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader_fails_invalid[value2-list-ValueError-invalid literal for int]
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader_fails_invalid[value3-dict-ValueError-invalid literal for int]
FAILED tests/config/loader/test_memory_loader.py::test_memory_loader_fails_invalid[value4-dict-ValueError-invalid literal for int]
FAILED tests/config/loader/test_str_convert.py::test_str_convert_ok[1-value17-set]
FAILED tests/config/loader/test_str_convert.py::test_str_convert_ok[1-value18-list]
FAILED tests/config/loader/test_str_convert.py::test_str_convert_ok[1=2-value19-dict]
FAILED tests/config/loader/test_str_convert.py::test_str_convert_ok[a=1\n\nc=2-value20-dict]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo "bar baz"-expected0]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo "bar baz"ext-expected1]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo="bar baz"-expected2]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo 'bar baz'-expected3]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo 'bar baz'ext-expected4]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo='bar baz'-expected5]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo=\\"bar baz\\"-expected6]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo="bar baz\\"-expected7]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo='bar baz' quuc-expected8]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo='bar baz\\' quuc-expected9]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo=\\"bar baz\\' quuc-expected10]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo=\\\\\\"bar baz\\"-expected11]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo=\\\\"bar baz\\"-expected12]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo\\\n    "bar\\\n    baz"-expected13]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo\\\n    "bar \\\n    baz"-expected14]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo \\\n    "bar\\\n    baz"-expected15]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo \\\n    "bar \\\n    baz"-expected16]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo \\\n    \\"bar \\\n    baz"-expected17]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-foo \\\n    bar \\\n    baz-expected18]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-SPECIAL:\\foo\\bar --quuz='baz atan'-expected19]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-X:\\\\foo\\\\bar --quuz='baz atan'-expected20]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-/foo/bar --quuz='baz atan'-expected21]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-cc --arg "C:\\\\Users\\""-expected22]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-cc --arg "C:\\\\Users\\"-expected23]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-cc --arg "C:\\\\Users"-expected24]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-cc --arg \\"C:\\\\Users"-expected25]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-cc --arg "C:\\\\Users\\ "-expected26]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-cc --arg "C:\\\\Users\\\\"-expected27]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-cc --arg "C:\\\\Users\\\\ "-expected28]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[win32-cc --arg C:\\\\Users\\\\ --arg2 "SPECIAL:\\Temp\\f o o" --arg3="\\\\FOO\\share\\Path name" --arg4 SPECIAL:\\Temp\\-expected29]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo "bar baz"-expected0]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo "bar baz"ext-expected1]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo="bar baz"-expected2]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo 'bar baz'-expected3]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo 'bar baz'ext-expected4]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo='bar baz'-expected5]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo=\\"bar baz\\"-expected6]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo="bar baz\\"-expected7]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo='bar baz' quuc-expected8]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo='bar baz\\' quuc-expected9]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo=\\"bar baz\\' quuc-expected10]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo=\\\\\\"bar baz\\"-expected11]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo=\\\\"bar baz\\"-expected12]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo\\\n    "bar\\\n    baz"-expected13]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo\\\n    "bar \\\n    baz"-expected14]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo \\\n    "bar\\\n    baz"-expected15]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo \\\n    "bar \\\n    baz"-expected16]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo \\\n    \\"bar \\\n    baz"-expected17]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-foo \\\n    bar \\\n    baz-expected18]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-SPECIAL:\\foo\\bar --quuz='baz atan'-expected19]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-X:\\\\foo\\\\bar --quuz='baz atan'-expected20]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-/foo/bar --quuz='baz atan'-expected21]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-cc --arg "C:\\\\Users\\""-expected22]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-cc --arg "C:\\\\Users\\"-expected23]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-cc --arg "C:\\\\Users"-expected24]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-cc --arg \\"C:\\\\Users"-expected25]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-cc --arg "C:\\\\Users\\ "-expected26]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-cc --arg "C:\\\\Users\\\\"-expected27]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-cc --arg "C:\\\\Users\\\\ "-expected28]
FAILED tests/config/loader/test_str_convert.py::test_shlex_platform_specific_ini[linux2-cc --arg C:\\\\Users\\\\ --arg2 "SPECIAL:\\Temp\\f o o" --arg3="\\\\FOO\\share\\Path name" --arg4 SPECIAL:\\Temp\\-expected29]
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_list_ok - Ty...
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_list_nok_element
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_dict_ok - Ty...
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_dict_nok - A...
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_dict_nok_key
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_dict_nok_value
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_command_ok
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_command_nok
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_list_optional_ok
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_list_optional_nok
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_list_literal_ok
FAILED tests/config/loader/test_toml_loader.py::test_toml_loader_list_literal_nok
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_core
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_non_default
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_extra
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_replace_posargs_default
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_replace_posargs_empty
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_replace_posargs_empty_optional
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_replace_posargs_set
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_replace_ref_of
FAILED tests/config/source/test_toml_pyproject.py::test_config_in_toml_replace_ref_env
FAILED tests/config/source/test_toml_pyproject.py::test_config_requires - Typ...
FAILED tests/config/source/test_toml_tox.py::test_config_in_toml_core - TypeE...
FAILED tests/config/source/test_toml_tox.py::test_config_in_toml_non_default
FAILED tests/config/source/test_toml_tox.py::test_config_in_toml_extra - Type...
FAILED tests/config/test_sets.py::test_config_set - AssertionError: assert ['...
FAILED tests/config/test_sets.py::test_config_dict - AssertionError: assert [...
FAILED tests/config/test_sets.py::test_config_bad_dict - Failed: DID NOT RAIS...
FAILED tests/plugin/test_plugin.py::test_plugin_hooks_and_order - AssertionEr...
FAILED tests/plugin/test_plugin.py::test_plugin_extend_pass_env - AssertionEr...
FAILED tests/plugin/test_plugin.py::test_plugin_extend_set_env - AssertionErr...
c: FAIL ✖ in 0.02 seconds
FAILED tests/session/cmd/test_parallel.py::test_parallel_run_live_out - Asser...
FAILED tests/session/cmd/test_parallel.py::test_parallel_show_output_with_pkg
FAILED tests/session/cmd/test_sequential.py::test_run_ignore_cmd_exit_code[-]
FAILED tests/session/cmd/test_sequential.py::test_run_ignore_cmd_exit_code[- ]
FAILED tests/session/cmd/test_sequential.py::test_run_sequential_fail - Asser...
FAILED tests/session/cmd/test_sequential.py::test_run_sequential_quiet - Asse...
FAILED tests/session/cmd/test_sequential.py::test_rerun_sequential_skip - Ass...
FAILED tests/session/cmd/test_sequential.py::test_rerun_sequential_wheel - As...
FAILED tests/session/cmd/test_sequential.py::test_recreate_package - Assertio...
FAILED tests/session/cmd/test_sequential.py::test_env_tmp_dir_reset - Asserti...
FAILED tests/session/cmd/test_sequential.py::test_commands_pre_fail_post_runs
FAILED tests/session/cmd/test_sequential.py::test_commands_pre_pass_post_runs_main_fails
FAILED tests/session/cmd/test_sequential.py::test_commands_post_fails_exit_code
FAILED tests/session/cmd/test_sequential.py::test_commands_ignore_errors[0-8-0-8]
FAILED tests/session/cmd/test_sequential.py::test_commands_ignore_errors[0-0-8-8]
FAILED tests/session/cmd/test_sequential.py::test_commands_ignore_errors[8-0-0-8]
FAILED tests/session/cmd/test_sequential.py::test_ignore_outcome - AssertionE...
FAILED tests/session/cmd/test_sequential.py::test_sequential_inserted_env_vars
FAILED tests/session/cmd/test_sequential.py::test_missing_command_success_if_ignored
FAILED tests/session/cmd/test_show_config.py::test_show_config_commands - ass...
FAILED tests/session/cmd/test_show_config.py::test_show_config_ini_comment_path
FAILED tests/session/test_env_select.py::test_label_core_can_define - Attribu...
FAILED tests/session/test_env_select.py::test_label_core_select - AttributeEr...
FAILED tests/session/test_env_select.py::test_label_core_and_trait - Attribut...
FAILED tests/session/test_env_select.py::test_matches_hyphenated_env[a] - Ass...
FAILED tests/session/test_env_select.py::test_matches_hyphenated_env[b] - Ass...
FAILED tests/session/test_env_select.py::test_matches_hyphenated_env[a-b] - A...
FAILED tests/session/test_env_select.py::test_matches_hyphenated_env[b-a] - A...
FAILED tests/session/test_env_select.py::test_matches_combined_env[3.10] - As...
FAILED tests/session/test_env_select.py::test_matches_combined_env[3.10-cov]
FAILED tests/session/test_env_select.py::test_matches_combined_env[3-cov] - A...
FAILED tests/session/test_env_select.py::test_matches_combined_env[3] - Asser...
FAILED tests/session/test_env_select.py::test_matches_combined_env[py3.10] - ...
FAILED tests/session/test_env_select.py::test_matches_combined_env[py310-cov]
FAILED tests/session/test_env_select.py::test_matches_combined_env[py3.10-cov]
FAILED tests/test_provision.py::test_provision_requires_nok - AttributeError:...
FAILED tests/test_provision.py::test_provision_no_recreate - AttributeError: ...
FAILED tests/test_provision.py::test_provision_no_recreate_json - AttributeEr...
FAILED tests/test_provision.py::test_provision_default_arguments_exists[r] - ...
FAILED tests/test_provision.py::test_provision_default_arguments_exists[p] - ...
FAILED tests/test_provision.py::test_provision_default_arguments_exists[de]
FAILED tests/test_provision.py::test_provision_default_arguments_exists[l] - ...
FAILED tests/test_provision.py::test_provision_default_arguments_exists[d] - ...
FAILED tests/test_provision.py::test_provision_default_arguments_exists[c] - ...
FAILED tests/test_provision.py::test_provision_default_arguments_exists[q] - ...
FAILED tests/test_provision.py::test_provision_default_arguments_exists[e] - ...
FAILED tests/test_provision.py::test_provision_default_arguments_exists[le]
FAILED tests/tox_env/python/test_python_api.py::test_python_set_hash_seed - A...
FAILED tests/tox_env/python/test_python_api.py::test_python_generate_hash_seed
FAILED tests/tox_env/python/test_python_api.py::test_python_keep_hash_seed - ...
FAILED tests/tox_env/python/test_python_api.py::test_python_disable_hash_seed
FAILED tests/tox_env/python/test_python_api.py::test_python_hash_seed_from_env_and_override
FAILED tests/tox_env/python/test_python_api.py::test_python_hash_seed_from_env_and_disable
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_single
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_multiple
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_include
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_not_table
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_missing
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_not_list
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_bad_requirement
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_bad_entry
FAILED tests/tox_env/python/test_python_runner.py::test_dependency_groups_cyclic
FAILED tests/tox_env/python/virtual_env/package/test_package_cmd_builder.py::test_build_wheel_external
FAILED tests/tox_env/python/virtual_env/package/test_package_cmd_builder.py::test_build_wheel_external_fail_build
FAILED tests/tox_env/python/virtual_env/package/test_package_cmd_builder.py::test_build_wheel_external_fail_many_pkg
FAILED tests/tox_env/python/virtual_env/package/test_package_pyproject.py::test_project_package_with_deps[sdist]
FAILED tests/tox_env/python/virtual_env/package/test_package_pyproject.py::test_project_package_with_deps[wheel]
FAILED tests/tox_env/python/virtual_env/package/test_package_pyproject.py::test_project_package_with_deps[editable]
FAILED tests/tox_env/python/virtual_env/package/test_package_pyproject.py::test_project_package_with_deps[editable-legacy]
FAILED tests/tox_env/python/virtual_env/package/test_package_pyproject.py::test_pyproject_config_settings_sdist
FAILED tests/tox_env/python/virtual_env/package/test_package_pyproject.py::test_pyproject_config_settings_wheel
FAILED tests/tox_env/python/virtual_env/package/test_package_pyproject.py::test_pyproject_config_settings_editable
FAILED tests/tox_env/python/virtual_env/package/test_package_pyproject.py::test_pyproject_config_settings_editable_legacy
FAILED tests/tox_env/test_api.py::test_ensure_temp_dir_exists - AssertionErro...
FAILED tests/tox_env/test_api.py::test_setenv_section_substitution - Assertio...
FAILED tests/tox_env/test_tox_env_api.py::test_allow_list_external_fail - Ass...
FAILED tests/tox_env/test_tox_env_api.py::test_env_log - AssertionError: code: 2
FAILED tests/tox_env/test_tox_env_api.py::test_change_dir_is_created_if_not_exist
==== 184 failed, 1609 passed, 11 skipped, 4 deselected in 89.83s (0:01:29) =====

And full pytest output in attachment python-tox.FAIL.txt

[jugmac00]

tox not necessarily drops support for Python versions immediately, which are no longer supported upstream.

FWIW, we do not use pyupgrade anymore, see 07658e6, where we switched to ruff.

@gaborbernat When do you want to drop support for Python 3.8?

And indeed, I can confirm, when I set target-version to py39 for ruff, a high number of tests (212 of ~1800) start to fail.

[gaborbernat]

I generally tend to do it soon after end of life of them. In this particular instance, however, because of the type annotation changes, There is a significant development requirement to do so. If at some point I or someone else gets to do it, that's why we do that.