chore: Remove deprecated library polyfill-library #491
+323
−857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
|
@styfle - The package was removed - so whats that correct thing to do then. Don't execute the test? |
|
We can't introduce breaking behavior and dropping a test would risk that. |
|
@styfle Readded test - but uncertain if the test won't fail now. |
styfle
reviewed
Feb 19, 2025
| if (integrationTest === 'polyfill-library.js') { | ||
| console.log('Skipping polyfill-library.js'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Not sure I understand this change. It has the same problem - you're not testing the polyfill-libarary.
Lets close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #490