Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: change configure to configuration #4024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

typo: change configure to configuration #4024

wants to merge 1 commit into from

Conversation

mahdikhashan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

it improve the clarity of the comment

Which issue(s) this PR fixes:

Fixes #4023

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 18, 2025
@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 18, 2025
@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. area/scheduling area/controllers area/cli area/dependency Issues or PRs related to dependency changes area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance area/test CI and test related Issues or PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2025
@Monokaix Monokaix removed kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. area/scheduling area/controllers area/cli area/dependency Issues or PRs related to dependency changes kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. kind/documentation Categorizes issue or PR as related to documentation. area/test CI and test related Issues or PRs area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes labels Feb 19, 2025
@Monokaix Monokaix removed area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance labels Feb 19, 2025
@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 21, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign monokaix
You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mahdikhashan
Copy link
Contributor Author

@Monokaix would you please review it again, I rebased it with master. thank you

@Monokaix
Copy link
Member

Hi, please squash to one commit.

@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2025
@mahdikhashan mahdikhashan force-pushed the typo-in-pkg-util branch 2 times, most recently from 615e4cb to f9a23f5 Compare February 21, 2025 10:11
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2025
@mahdikhashan mahdikhashan force-pushed the typo-in-pkg-util branch 2 times, most recently from e02bd70 to db3a49a Compare February 21, 2025 10:12
@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2025
@mahdikhashan
Copy link
Contributor Author

Hi, please squash to one commit.

done. (rebased instead). thanks for your time.

@hwdef
Copy link
Member

hwdef commented Feb 24, 2025

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@Monokaix Monokaix Awaiting requested review from Monokaix

At least 1 approving review is required to merge this pull request.

Assignees

@hwdef hwdef

@Monokaix Monokaix

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo: in pkg/cli/util/util.go the configure should be configuration
4 participants
@mahdikhashan @Monokaix @volcano-sh-bot @hwdef