Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies of expo demo #2769

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix dependencies of expo demo #2769

merged 1 commit into from
Oct 18, 2023

Conversation

ethanshar
Copy link
Collaborator

Description

Fix dependencies of expo demo
fix #2295

Changelog

Fix expo demo app

Additional info

@ethanshar ethanshar requested a review from M-i-k-e-l October 17, 2023 06:38
@M-i-k-e-l M-i-k-e-l merged commit 2507794 into master Oct 18, 2023
ethanshar added a commit that referenced this pull request Oct 26, 2023
* Added default horizonatl margins to the right icon in chips

* Changed margins in chip when right icon is rendered with anything

* Reverted formatting

* Changed margins for the icons in the chip. added margin handling when there are icons/elements of both sides of the chip

* Icon margins only handles in the label margins

* Lowered margin from element

* Fix dependencies of expo demo (#2769)

* Formattings

* Changes to margin condtions handling

* Revert expoDemo/package.json changes

This reverts commit 2507794.

---------

Co-authored-by: Ethan Sharabi <[email protected]>
@ethanshar ethanshar deleted the fix/expoDemoDeps branch April 2, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo Demo App outdated
2 participants