issue-258 - Create a single machine Vagrantfile #369
Conversation
| @@ -5,8 +5,8 @@ consul_advertise: "{{ ansible_eth1.ipv4.address }}" | |||
| consul_bind_addr: "{{ ansible_eth1.ipv4.address }}" | |||
| marathon_hostname: "{{ ansible_eth1.ipv4.address }}" | |||
| mesos_hostname: "{{ ansible_eth1.ipv4.address }}" | |||
| mesos_master_quorum: 2 | |||
There was a problem hiding this comment.
This (mesos_master_quorum and consul_bootstrap_expect) could probably be removed from here now as we are passing it explicitly.
|
We probably want to add how to use the standalone version in the Vagrant Docs. I'd be in favour of making a one dynamic Vagrantfile supporting any number of masters/slaves including the standalone so we DRY. Then the yaml file with the settings could be set as an environment var. e.g vagrant_cluster=vagrant-standalone.yaml |
|
The work here looks mostly fine, needs rebased and a couple of comments addressing. |
|
I will try put the logic to one Vagrantfile as enxebre suggested and clean the code, I will update the documentation as well. Tayzlor I am gonna use the same script which we use now (apollo-launch.sh) everything what we need to do is to set an environment var which switch vagrant configuration between two files (vagrant.yml/vagrant-standalone.yml). Thank you for your answers. |
|
|
||
| node = conf['masters'] | ||
|
|
||
| mesos_zk_url = "zk://"+node['ip']+":2181/mesos" |
There was a problem hiding this comment.
can you line all the = up so its a bit more readable here (same below)
|
PR looks ready to merge, but looks like it needs rebased due to some conflict first. If you do that, we can merge it |
|
I've just fixed the conflict. Tayzlor, could you merge it. |
issue-258 - Create a single machine Vagrantfile
Created a single machine Vagrantfile