Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to find universal binaries on macOS for ndk_setup.sh/ndk_unset.sh #24

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

tkmru
Copy link
Contributor

@tkmru tkmru commented Aug 17, 2022

最近のmacOS向けのNDK内のclang/clang++バイナリはuniversal binaryになっているようです。
universal binaryはfind -type fだと見つけられないことがわかったので、対応するためのプルリクエストです。

$ find "/Users/tkmru/Library/Android/sdk/ndk/23.2.8568313" -type f -name clang++
何もでない

$ find "/Users/tkmru/Library/Android/sdk/ndk/23.2.8568313" -name clang++
/Users/tkmru/Library/Android/sdk/ndk/23.2.8568313/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++

$ file /Users/tkmru/Library/Android/sdk/ndk/23.2.8568313/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++
/Users/tkmru/Library/Android/sdk/ndk/23.2.8568313/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
/Users/tkmru/Library/Android/sdk/ndk/23.2.8568313/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ (for architecture x86_64):	Mach-O 64-bit executable x86_64
/Users/tkmru/Library/Android/sdk/ndk/23.2.8568313/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ (for architecture arm64):	Mach-O 64-bit executable arm64

@tkmru tkmru changed the title Changed to find universal binaries on macOS Changed to find universal binaries on macOS for ndk_setup.sh/ndk_unset.sh Aug 17, 2022
@funa-tk
Copy link
Contributor

funa-tk commented Aug 17, 2022

ありがとうございます!
マージします

@funa-tk funa-tk merged commit 04ab186 into DeNA:swift/release/5.5 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants