Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-light theme #175

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Conversation

Evavic44
Copy link
Contributor

@Evavic44 Evavic44 commented Oct 5, 2021

Description

Add github-light theme

Fixes #32 #173

Type of change

  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

github-commit-light

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Oct 5, 2021

Writing "Fixes" before an issue number makes it close the issue when the PR is merged, please only write the issue you want to close (eg. Fixes #173) and not 32 because then I have to reopen it every time.

Also, could you merge the main branch if you don't mind.

Thanks 😊

@Evavic44
Copy link
Contributor Author

Evavic44 commented Oct 5, 2021

Writing "Fixes" before an issue number makes it close the issue when the PR is merged, please only write the issue you want to close (eg. Fixes #173) and not 32 because then I have to reopen it every time.

Also, could you merge the main branch if you don't mind.

Thanks 😊

Oh.... sorry about that. 😂 Merging now.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@DenverCoder1 DenverCoder1 merged commit 7e3c7e9 into DenverCoder1:main Oct 5, 2021
@DenverCoder1 DenverCoder1 mentioned this pull request Oct 5, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎨 Add more themes
2 participants