Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated French translation of Longest Week Streak #413

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix: Updated French translation of Longest Week Streak #413

merged 1 commit into from
Jan 11, 2023

Conversation

maelgangloff
Copy link
Contributor

Description

The translation of Longest Week Streak was Plus longue de semaine séquence. This is not grammatically correct in French, which is why I propose this fix by replacing it with Plus longue séquence hebdomadaire.

Type of change

  • [x ] Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title fix: best French translation of Longest Week Streak fix: Updated French translation of Longest Week Streak Jan 11, 2023
@DenverCoder1 DenverCoder1 merged commit 84fb6f5 into DenverCoder1:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants