Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Sanskrit translations #444

Merged
merged 2 commits into from
Feb 2, 2023
Merged

feat: Added Sanskrit translations #444

merged 2 commits into from
Feb 2, 2023

Conversation

Ishika-08
Copy link
Contributor

@Ishika-08 Ishika-08 commented Feb 2, 2023 •
edited
Loading

Description

Added Sanskrit translations to translations.php

Fixes # Issue 236

Type of change

  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

DenverCoder1
DenverCoder1 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

DenverCoder1
DenverCoder1 reviewed Feb 2, 2023
View reviewed changes
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-patch-1-jyxgl2pqy February 2, 2023 16:32 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-patch-1-igb2hhhsx February 2, 2023 16:36 Inactive
@DenverCoder1 DenverCoder1 changed the title Added Sanskrit translations feat: Added Sanskrit translations Feb 2, 2023
@DenverCoder1 DenverCoder1 merged commit 45bfc83 into DenverCoder1:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ishika-08 @DenverCoder1