Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added neon theme #473

Merged
merged 4 commits into from
Mar 15, 2023
Merged

feat: Added neon theme #473

merged 4 commits into from
Mar 15, 2023

Conversation

anirban12d
Copy link
Contributor

@anirban12d anirban12d commented Mar 15, 2023

This theme has bright colors that works well with dark backgrounds.

Description

Fixes #

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

This theme has bright colors that works well with dark backgrounds.
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Would you be able to also update the docs - https://github.com/anirban12d/github-readme-streak-stats/blob/patch-1/docs/themes.md?

image

Here's an image url that can be used - https://user-images.githubusercontent.com/20955511/225303106-8c901c48-732e-49ae-a2e6-8733254536eb.png

diff --git a/docs/themes.md b/docs/themes.md
index c1f8ee4..8c610bf 100644
--- a/docs/themes.md
+++ b/docs/themes.md
@@ -121,6 +121,7 @@ Note: Theme names provided are case-insensitive and any use of underscores will
 |         `date-night`          | ![image](https://user-images.githubusercontent.com/20955511/221585779-db7f394d-b3c6-49e4-ad75-bbba97530765.png)  |
 |        `one-dark-pro`         | ![image](https://user-images.githubusercontent.com/20955511/221585805-1d10928a-286c-4945-95ed-a7317e56692f.png)  |
 |            `rose`             | ![image](https://user-images.githubusercontent.com/20955511/221585827-e566b73a-e0c0-4711-b48c-667e6500d44e.png)  |
+|            `neon`             | ![image](https://user-images.githubusercontent.com/20955511/225303106-8c901c48-732e-49ae-a2e6-8733254536eb.png)  |
 
 ### Can't find the theme you like?
 
diff --git a/src/themes.php b/src/themes.php
index 3eb5ea9..6db9e8d 100644
--- a/src/themes.php
+++ b/src/themes.php
@@ -1358,10 +1358,10 @@ return [
         "sideLabels" => "#8D192B",
         "dates" => "#862931",
     ],
-     "neon" => [
+    "neon" => [
         "background" => "#000000",
-        "border" => "#ffffff",
-        "stroke" => "#ffffff",
+        "border" => "#FFFFFF",
+        "stroke" => "#FFFFFF",
         "ring" => "#00EAD3",
         "fire" => "#00EAD3",
         "currStreakNum" => "#FF449F",

Let me know if you have any questions.

@anirban12d
Copy link
Contributor Author

Updated the docs.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Added neon theme feat: Added neon theme Mar 15, 2023
@DenverCoder1 DenverCoder1 merged commit e1d6442 into DenverCoder1:main Mar 15, 2023
@anirban12d
Copy link
Contributor Author

You are most welcome. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants