Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Swap first and third columns when direction is rtl #496

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

DenverCoder1
Copy link
Owner

Description

Swapped locations of total contributions and longest streak for right-to-left languages.

Naturally, when a language is read right to left, the order of elements are reversed.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

image

@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Apr 17, 2023
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-swap--iz7xgq April 17, 2023 20:55 Inactive
@DenverCoder1 DenverCoder1 merged commit e08a590 into main Apr 17, 2023
@DenverCoder1 DenverCoder1 deleted the feat/swap-columns-rtl branch April 17, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant