Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve label accessibility and demo initialization #500

Merged
merged 6 commits into from
Apr 18, 2023

Conversation

DenverCoder1
Copy link
Owner

Description

Improved accessibility by using labels and groups according to documentation (label "for" should match the "id" of an input, aria-labelledby can be used for labelling groups of inputs)

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 added the refactor Code changes that do not affect the application behavior label Apr 18, 2023
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-refactor-a-fzqxa8 April 18, 2023 10:00 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-refactor-a-zxfvk8 April 18, 2023 10:11 Inactive
@DenverCoder1 DenverCoder1 changed the title refactor: Use label 'for' attributes and groups properly refactor: Improve label accessibility and demo initialization Apr 18, 2023
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-refactor-a-zxfvk8 April 18, 2023 10:12 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-refactor-a-wri9md April 18, 2023 10:18 Inactive
@DenverCoder1 DenverCoder1 merged commit f516baf into main Apr 18, 2023
@DenverCoder1 DenverCoder1 deleted the refactor/aria-labels-and-groups branch April 18, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that do not affect the application behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant