Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed and updated Danish translations #533

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

MoistGoolem
Copy link
Contributor

Description

Changed multiple danish translations which were incorrect, misleading or directly translated from english (too "Google translatey").

Fixes # 236

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

Untested. It's a simple string change.

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@DenverCoder1
Copy link
Owner

Looks great, thanks for fixing it.

Do you want to also add the missing phrase to the Danish translations. The one that is missing is "Excluding" shown below.

image

Thanks!

@MoistGoolem
Copy link
Contributor Author

Sure I'll take a look 👍

@MoistGoolem
Copy link
Contributor Author

Busy weekend without pc but here's the final translation

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Changed wrong and/or confusing danish translations feat: Fixed and updated Danish translations Jun 19, 2023
@DenverCoder1 DenverCoder1 merged commit 66fa421 into DenverCoder1:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants