Toggle demo clipboard visibility between JSON, and Markdown and HTML #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
between when type is set to JSON and when not when set to JSON, markdown and HTML clipboards not visible and disabled when not set to JSON, JSON clipboard not visible and disabled
DenverCoder1
reviewed
Oct 3, 2023
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Sorry, I was unable to test using Heroku. |
|
You can test locally or in a codespace with php installed, I'll enable a review app so it can be tested on Heroku in this PR. The View Deployment button should appear above. |
DenverCoder1
reviewed
Oct 3, 2023
Thank you for your help @DenverCoder1. The copy from clipboard functionality when the type is JSON is now fixed! |
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functionality to toggle between JSON, and Markdown and HTML clipboard visibility on demo site when the type variable is set to json and when not, respectively.
Fixes #572
Type of change
How Has This Been Tested?
composer testChecklist:
Screenshots