feat: Add option to use short number format #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the option to display the Total Contributions count in short form. * Add a new parameter `short_total_contributions` to the `generateCard` function in `src/card.php` with a default value of `false`. * Implement a `shortNumber` function in `src/card.php` to convert large numbers into short form. * Update the `generateCard` function in `src/card.php` to use the `shortNumber` function if `short_total_contributions` is `true`. * Use the `shortNumber` function for current streak and longest streak if `short_total_contributions` is `true`. * Add a new input field for `short_total_contributions` in the form in `src/demo/index.php`. * Add a test case for the new `short_total_contributions` parameter in `tests/RenderTest.php`.
DenverCoder1
temporarily deployed
to
streak-stats-add-short--vneqo1
DenverCoder1
temporarily deployed
to
streak-stats-add-short--vneqo1
DenverCoder1
temporarily deployed
to
streak-stats-add-short--vneqo1
DenverCoder1
temporarily deployed
to
streak-stats-add-short--vneqo1
DenverCoder1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #729
This pull request introduces a new feature to format numbers using locale and short number notation. The changes include adding a new function for number formatting, integrating this function into the card generation process, and updating the demo and tests to support the new feature.
New Feature: Short Number Formatting
src/card.php: AddedformatNumberfunction to format numbers using locale and short number notation. Integrated this function into thegenerateCardmethod to replace the existing number formatting logic. [1] [2] [3] [4]src/demo/index.php: Added a new dropdown in the demo interface to enable or disable short number formatting.src/demo/js/script.js: Updated the preview object to include theshort_numbersparameter.tests/RenderTest.php: Added a test case to verify the short number formatting feature.