Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client demo that implement open direct tcpip. #454

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Conversation

handewo
Copy link
Contributor

@handewo handewo commented Jan 26, 2025

This demo works like ssh -L <bind_addr:forward_addr> -N <host>
Known issue: forward data sometimes incorrect since not handle ChannelMsg::WindowAdjusted, but I think it's not important as demo.

@Eugeny
Copy link
Owner

Eugeny commented Jan 27, 2025

Thank you for the PR. I'd rather not overload the new example with certificate handling. If you'd like, you can instead add the certificates support to client_exec_simple

@handewo
Copy link
Contributor Author

handewo commented Feb 5, 2025

Thank you for the PR. I'd rather not overload the new example with certificate handling. If you'd like, you can instead add the certificates support to client_exec_simple

No problem. I've added.

@Eugeny
Copy link
Owner

Eugeny commented Feb 5, 2025

Could you please also remove the usage of async_trait to fix the build? It's now optional in the crate and shouldn't be used in the examples

@handewo
Copy link
Contributor Author

handewo commented Feb 6, 2025

Could you please also remove the usage of async_trait to fix the build? It's now optional in the crate and shouldn't be used in the examples

Done.

@Eugeny Eugeny merged commit 6a59d0e into Eugeny:main Feb 8, 2025
7 checks passed
@Eugeny
Copy link
Owner

Eugeny commented Feb 8, 2025

Thanks! @all-contributors add @handewo for code

Copy link
Contributor

@Eugeny

I've put up a pull request to add @handewo! 🎉

Eugeny pushed a commit that referenced this pull request Feb 9, 2025
Adds @handewo as a contributor for code.

This was requested by Eugeny [in this
comment](#454 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants