Change the default download behaviour to the better "Open in web browser" value #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Feb 17, 2024
PikachuEXE
approved these changes
Feb 17, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 17, 2024
github-actions
bot
removed
the
PR: waiting for review
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default download behaviour to the better "Open in web browser" value
Pull Request Type
Description
As discussed with the other maintainers, this pull request changes the default download behaviour to the objectively better "Open in web browser" option.
When the pull request that added the minimal "Download in app" option was introduced, it was done so with the expectation that it would be expanded upon not long afterwards. As it's now two years later and the in-app downloader hasn't been improved, we should definitely not default to it. While the "Open in web browser" option isn't great either, it is the lesser of two evils, as web browsers generally come with download managers, including being able to view progress, pause and resume downloads.
If users want to use the incomplete in-app downloader, they can still opt into it by changing the setting, we just will no longer use it as a default.
Desktop