Keep the video options button visible when the dropdown is open #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 16, 2024
PikachuEXE
approved these changes
Mar 17, 2024
ChunkyProgrammer
approved these changes
Mar 25, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 26, 2024
* fix-pageheader-subs: Fix extracting the subscriber count from channel PageHeader nodes ! Fix handling of video data without `published` (FreeTubeApp#4788) Keep the video options button visible when the dropdown is open (FreeTubeApp#4771) Bump the babel group with 3 updates (FreeTubeApp#4797) Bump the stylelint group with 2 updates (FreeTubeApp#4799) Bump the eslint group with 2 updates (FreeTubeApp#4798) Bump webpack-dev-server from 5.0.3 to 5.0.4 (FreeTubeApp#4800) Bump webpack from 5.90.3 to 5.91.0 (FreeTubeApp#4801) Bump electron from 29.1.4 to 29.1.5 (FreeTubeApp#4802) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Finnish) Bump webpack-dev-middleware from 7.0.0 to 7.1.1 (FreeTubeApp#4789)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the video options button visible when the dropdown is open
Pull Request Type
Description
This pull request fixes the options (three dots button) button fading away/disappearing while the dropdown is open when you move the mouse away. In my opinion we shouldn't be fading away elements when the user has explicitly interacted with them, especially in the case of the dropdown where the user wants to do something with the drop down, so it disappearing in front of their eyes while they are making the decision is a bad UX.
Testing
Click on the options button (three dots button) on a video in a video list (e.g. subscriptions and search results) so that the drop down opens, then move your mouse away from that video and make sure that the button and the drop down stay visible for as long as the drop down is open.
Desktop